-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pull_translations: use less Makefile commands and move it to Python | FC-0012 #34257
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
…ython `mkdir` should be in Python
fa039d0
to
25b3794
Compare
@feanil this is a minor pull request that I'd love a quick review for. @shadinaif please also verify locally so we have two testers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thanks @feanil!! |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
mkdir
should be in Python also replacingcp -r
with acms
command to avoid confusing future maintainers. These are notes from Regis on Tutor, but needs anedx-platform
fix.Testing
lms make OPENEDX_ATLAS_PULL=yes pull_translations
on your devstack and it should pull translations.Deadline
As soon as possible, to meet FC-0012 timeline and help merge Tutor PR:
Other information
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.