Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create get_course_videos_qset API call #554

Closed
wants to merge 1 commit into from

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Jan 15, 2025

This new call returns a CourseVideo queryset that will allow callers to
efficiently get what they want, instead of having to bring back a large
serialized object that may have many fields that they don't care about.

This new call returns a CourseVideo queryset that will allow callers to
efficiently get what they want, instead of having to bring back a large
serialized object that may have many fields that they don't care about.
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (f0ae16d) to head (104c561).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   94.57%   94.58%   +0.01%     
==========================================
  Files          32       32              
  Lines        3171     3178       +7     
  Branches      122      122              
==========================================
+ Hits         2999     3006       +7     
  Misses        154      154              
  Partials       18       18              
Flag Coverage Δ
unittests 94.58% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ormsbee
Copy link
Contributor Author

ormsbee commented Jan 15, 2025

@jansenk, @BrandonHBodine: Hi folks. I'm creating this PR to enable openedx/edx-platform#36112, which will make the course quality checks that load in the Studio outline page much faster for those courses that use edx-val extensively. I don't understand what's going on with the Pact stuff though.

@DawoudSheraz
Copy link
Contributor

@jansenk, @BrandonHBodine: Hi folks. I'm creating this PR to enable openedx/edx-platform#36112, which will make the course quality checks that load in the Studio outline page much faster for those courses that use edx-val extensively. I don't understand what's going on with the Pact stuff though.

It seems the auth call to edx.pactflow.io is failing with 401. I don't have access to see the secret values on Github. Can you help check if PACT_FLOW_ACCESS_TOKEN is configured/present? Looking at edx.pactflow.io, the token was last used on January 13, so it is possible the config got removed from Open edX org secrets.

@ormsbee
Copy link
Contributor Author

ormsbee commented Jan 15, 2025

@DawoudSheraz: I'll look into that, thank you!

@ormsbee
Copy link
Contributor Author

ormsbee commented Jan 15, 2025

@DawoudSheraz: PACT_FLOW_ACCESS_TOKEN exists and this repo has access to it. Is it possible that the token expired and we need to put a new value for it?

@DawoudSheraz
Copy link
Contributor

@DawoudSheraz: PACT_FLOW_ACCESS_TOKEN exists and this repo has access to it. Is it possible that the token expired and we need to put a new value for it?

Hmmm, strange. The token does not have an explicit expiry date.

@DawoudSheraz
Copy link
Contributor

Weird, I triggered the requirements upgrade flow job and pact CI is passing there #555

@DawoudSheraz
Copy link
Contributor

I understand what is going on here. The PRs are being made using the fork, the direct push/write access is not available anymore. In that case, Github actions try to read the secret from fork's Github account rather than Open edX Github org secrets (https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow). Because the secret is not available in fork (obviously), pact is not able to authenticate with pactflow and raises 401.

@ormsbee
Copy link
Contributor Author

ormsbee commented Jan 16, 2025

Huh. I guess I'll close this and re-open with a branch on this repo. That will be problematic for a lot of contributors though. FYI @feanil

@ormsbee
Copy link
Contributor Author

ormsbee commented Jan 16, 2025

Closing because of Pact auth issues. Will re-open as a branch on this repo instead.

@ormsbee ormsbee closed this Jan 16, 2025
@ormsbee ormsbee deleted the video-quality-optimization branch January 16, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants