-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create get_course_videos_qset API call #554
Conversation
This new call returns a CourseVideo queryset that will allow callers to efficiently get what they want, instead of having to bring back a large serialized object that may have many fields that they don't care about.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
==========================================
+ Coverage 94.57% 94.58% +0.01%
==========================================
Files 32 32
Lines 3171 3178 +7
Branches 122 122
==========================================
+ Hits 2999 3006 +7
Misses 154 154
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jansenk, @BrandonHBodine: Hi folks. I'm creating this PR to enable openedx/edx-platform#36112, which will make the course quality checks that load in the Studio outline page much faster for those courses that use edx-val extensively. I don't understand what's going on with the Pact stuff though. |
It seems the auth call to edx.pactflow.io is failing with 401. I don't have access to see the secret values on Github. Can you help check if PACT_FLOW_ACCESS_TOKEN is configured/present? Looking at edx.pactflow.io, the token was last used on January 13, so it is possible the config got removed from Open edX org secrets. |
@DawoudSheraz: I'll look into that, thank you! |
@DawoudSheraz: |
Hmmm, strange. The token does not have an explicit expiry date. |
Weird, I triggered the requirements upgrade flow job and pact CI is passing there #555 |
I understand what is going on here. The PRs are being made using the fork, the direct push/write access is not available anymore. In that case, Github actions try to read the secret from fork's Github account rather than Open edX Github org secrets (https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow). Because the secret is not available in fork (obviously), pact is not able to authenticate with pactflow and raises 401. |
Huh. I guess I'll close this and re-open with a branch on this repo. That will be problematic for a lot of contributors though. FYI @feanil |
Closing because of Pact auth issues. Will re-open as a branch on this repo instead. |
This new call returns a CourseVideo queryset that will allow callers to
efficiently get what they want, instead of having to bring back a large
serialized object that may have many fields that they don't care about.