feat: informative errors on failure to download or create shared record #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds user-facing errors if errors appear on download or creation of shared program record. FIXES: APER-3170
lint errors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 70.87% 73.25% +2.37%
==========================================
Files 28 28
Lines 412 415 +3
Branches 89 89
==========================================
+ Hits 292 304 +12
+ Misses 119 110 -9
Partials 1 1 ☔ View full report in Codecov by Sentry. |
FIXES: APER-3170
deborahgu
added
the
waiting for eng review
MaxFrank13
reviewed
Jan 13, 2025
| @@ -268,7 +286,7 @@ ProgramRecordActions.propTypes = { | |||
| renderBackButton: PropTypes.func.isRequired, | |||
| username: PropTypes.string.isRequired, | |||
| programUUID: PropTypes.string.isRequired, | |||
| sharedRecordUUID: PropTypes.string.isRequired, | |||
| sharedRecordUUID: PropTypes.string, | |||
There was a problem hiding this comment.
If we make this not required, it is probably good to have it default to an empty string. We can do that with defaultProps. Here is an example in the ProgramRecordAlert component.
Apologies for not catching this last week!
MaxFrank13
approved these changes
Jan 13, 2025
per code review
missing semicolon
deborahgu
deleted the
dkaplan1/APER-3170_silent-failure-attempting-to-click-“create-program-record-link”
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds user-facing errors if errors appear on download or creation of shared program record.
FIXES: APER-3170