-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prequery search suggestions #371
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 78.37% 78.61% +0.23%
==========================================
Files 34 34
Lines 666 692 +26
Branches 170 179 +9
==========================================
+ Hits 522 544 +22
- Misses 131 135 +4
Partials 13 13
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of thoughts, some suggestions/questions but otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except a couple nits! One question is with the "view all results" at the bottom, it doesn't seem to do much cause it just takes you back to the same query (instead of going to just courses for example) is this expected?
Description
We want to add a prequery suggestions to the learner portal using the bayesian average that was added to algolia. The idea being when the course search box is focused, we give a drop down box selection of suggested courses based on their review data.
Related PR in learner portal: #935
JIRA
Screen.Recording.2024-01-30.at.12.31.34.AM.mov
Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).