-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for loading external theme CSS for MFEs #689
feat: adds support for loading external theme CSS for MFEs #689
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 83.36% 86.70% +3.34%
==========================================
Files 40 48 +8
Lines 1070 1392 +322
Branches 197 295 +98
==========================================
+ Hits 892 1207 +315
- Misses 166 172 +6
- Partials 12 13 +1 ☔ View full report in Codecov by Sentry. |
aee582b
to
e81b549
Compare
5b4c843
to
ed293e3
Compare
@dcoa I'm getting an error during build related to the
I tried to solve it by changing the export to Have you encountered such a problem? |
@PKulkoRaccoonGang this is related to frontend-build changes, I'm checking right now This line is making that the app is not rendering in frontend-platform https://github.com/openedx/frontend-build/pull/546/files#diff-22e13ddf245ea4fa81ca4d686dddf46fa9cbf70fbbff99991cccbf0c8ff82316R175 If you remove it, you will be able to see the app. Update I made an update to webpack dev config for example app and is working now. |
9ebae07
to
94e4a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcoa This looks great! I have already started working on Update openedx/frontend-app-discussions
. I left a few questions about the operation of some features and the code in general.
a6a9211
to
229d79a
Compare
06fc4e6
to
837858e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking great! I left a suggestion to clarify the documentation is referring to design tokens, and a few comments noting PRs that need to land before this can.
Thank you so much for this!
2565f02
to
ae5b53f
Compare
…rocessing is done
Co-authored-by: Brian Smith <[email protected]>
ff8c977
to
250ee46
Compare
Great to see this merge! 🥳 |
Description:
This PR updates the original one #440 closer to the master branch and adds some extra tests.
Please read the original PR for additional context.
Warning
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: