Skip to content

Commit

Permalink
Merge pull request #238 from edx-solutions/djoy/TNL-7184_less_publish…
Browse files Browse the repository at this point in the history
…_events

fix: Properly limit 'feedback.opened' events
  • Loading branch information
davidjoy authored Apr 14, 2020
2 parents 1a82115 + f79b211 commit e2e21e6
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 4 deletions.
35 changes: 33 additions & 2 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,37 @@
Drag and Drop XBlock changelog
==============================

Version 2.2.10 (2020-04-14)
---------------------------

* Fix bug where 'edx.drag_and_drop_v2.feedback.opened' event was sent to publish_event endpoint excessively on mouse move. (PR #238)

Version 2.2.9 (2020-04-03)
--------------------------

* Updated fragment import to remove deprecation warning which was causing extra logs in Splunk etc.

Version 2.2.8 (2020-01-13)
--------------------------

* Updated code to render custom zone title as HTML

Version 2.2.7 (????-??-??)
-------------------

* NOTE: This version was skipped / is not documented.

Version 2.2.6 (2019-10-08)
--------------------------

* Python3 compatible.

Version 2.2.5 (2019-10-04)
--------------------------

* This repository is now python3 compatible.
* Update the xblock-sdk hash which is python3 compatible also.

Version 2.2.4 (2019-07-30)
---------------------------

Expand Down Expand Up @@ -56,7 +87,7 @@ Version 2.1.5 (2017-11-06)
Version 2.1.4 (2017-11-06)
---------------------------

* Make XBlock always emit `progress` event explicitly when it is marked as complete.
* Make XBlock always emit `progress` event explicitly when it is marked as complete.

Version 2.1.3 (2017-10-05)
---------------------------
Expand Down Expand Up @@ -92,7 +123,7 @@ Version 2.0.12 (2016-11-08)
* [SOL-2094][sol-2094] Fixed problem preventing DnDv2 blocks from being scored or graded.
* Highest grade achieved is now displayed in feedback area
* Renamed "Maximum score" field to "Problem Weight" to be in line with CAPA problems and avoid confusion.

[sol-2030]: https://openedx.atlassian.net/browse/SOL-2030
[sol-2094]: https://openedx.atlassian.net/browse/SOL-2094

Expand Down
2 changes: 1 addition & 1 deletion drag_and_drop_v2/public/js/drag_and_drop.js
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ function DragAndDropBlock(runtime, element, configuration) {
delete state.closing;
}
// Has feedback been set?
if (state.feedback) {
if (state.feedback && state.feedback.length > 0) {
var data = {
event_type: 'edx.drag_and_drop_v2.feedback.opened',
content: concatenateFeedback(state.feedback),
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def package_data(pkg, root_list):

setup(
name='xblock-drag-and-drop-v2',
version='2.2.9',
version='2.2.10',
description='XBlock - Drag-and-Drop v2',
packages=['drag_and_drop_v2'],
install_requires=[
Expand Down

0 comments on commit e2e21e6

Please sign in to comment.