Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#820 emob mit sanity checks #889

Merged
merged 16 commits into from
Sep 22, 2022
Merged

Conversation

nesnoj
Copy link
Member

@nesnoj nesnoj commented Aug 25, 2022

Closes #820

Requires merge of #922

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nesnoj nesnoj self-assigned this Aug 25, 2022
@nesnoj
Copy link
Member Author

nesnoj commented Aug 26, 2022

Codacy fails: https://app.codacy.com/gh/openego/eGon-data/pullRequest?prid=10050119
While I can fix the Too many local variables issues, the other two:

  • Value 'ts' is unsubscriptable (unsubscriptable-object)
  • Lambda may not be necessary (unnecessary-lambda)

are simply not true. Seems that pylint fails at code analysis (there're quite some bug reports on false positives of e.g. unsubscriptable-object). So I tried to suppress them in 28ae5d6 but suppressing seems to be disabled by default and I reverted the suppression. Now I tend to just don't care anymore (following #56). @gnn please drop me a line if you have objections.

@nesnoj nesnoj marked this pull request as ready for review September 7, 2022 09:14
@nesnoj nesnoj merged commit 5a2bf52 into dev Sep 22, 2022
@nesnoj nesnoj deleted the features/#820-emob-mit-sanity-checks branch September 22, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sanity checks for eMob MIT
1 participant