update extendable link carrier in foreign countries #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
| "H2 Electrolysis", | ||
| "H2 Fuel Cell", | ||
| "SMR", | ||
| "Sabatier", |
There was a problem hiding this comment.
Looks good to me.
Some of the carrier names are still not in line with the ones we use within Germany. But that is maybe another issue, right?
There was a problem hiding this comment.
at this point, it should or even has to work with the p-e wording since it is at that point still not changed. You are right it is another issue but I think most of the names are tackled already. But I will check if we can add s.th. there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # #371 .
Before merging into
dev-branch, please make sure thatCHANGELOG.rstwas updated.blackandisort.Dataset-version is updated when existing datasets are adjusted.continuous-integration/run-everything-over-the-weekend-branch.test mode.Everythingmode.