fix: On boarding dark mode fix #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshAman999
changed the title
teolemon
added
🤗 Onboarding
2 tasks
M123-dev
approved these changes
Mar 29, 2022
|
But there are some conflicts to solve @AshAman999 |
on-boarding-dark-mode-fix
|
Thanks for changing @AshAman999 also good that you provided the screen records, while watching them I noticed that in light mode the next page button has a solid background, in darkmode not. It would be good if you could add it / make it visibile in the darkmode too |
|
|
M123-dev
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Had to revert the changes as I did the change in consent page too but found out it was already in a pr
Screenshot
dark_theme.mp4
light_theme.mp4
Fixes bug(s)
Part of