feat: Add privacy policy link in app

[AshAman999]

What

• Added the about privacy page section

Screenshot

Fixes bug(s)

• Fixes: Add the privacy policy page #5053

Part of

• 🎯 What can I work on ? #525

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4d9c7fc) 9.54% compared to head (7fb24c2) 9.54%.
Report is 28 commits behind head on develop.

Files	Patch %	Lines
...pp/lib/pages/preferences/user_preferences_faq.dart	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5074      +/-   ##
==========================================
- Coverage     9.54%   9.54%   -0.01%     
==========================================
  Files          325     326       +1     
  Lines        16411   16437      +26     
==========================================
+ Hits          1567    1569       +2     
- Misses       14844   14868      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[monsieurtanuki]

Hi @AshAman999!
Looks relatively good to me.
Please consider localizing the URL as suggested, or merging anyway.

[monsieurtanuki]

Suggested change

	onPressed: () => LaunchUrlHelper.launchURL(
	'https://openfoodfacts.org/privacy',
	true,
	),
	onPressed: () async => LaunchUrlHelper.launchURL(
	UriHelper.replaceSubdomain(
	Uri.parse(
	'https://world.openfoodfacts.org/privacy',
	),
	),
	true,
	),

[AshAman999]

@monsieurtanuki

I think LaunchUrlHelper.launchURL automatically does that if passed with true as Boolean, so in a way it gets localized.

Can you plz have a look once

[monsieurtanuki]

@AshAman999 You're right!

[teolemon]

The string should be made translatable / adapt to the language

[monsieurtanuki]

@teolemon Actually in the code the URL is "localized", country-wise.
The true parameter is not very explicit, I'll give you that, and it only sets the country - not the language, e.g. https://be.openfoodfacts.org/privacy (and not https://be-fr.openfoodfacts.org/privacy or https://be.openfoodfacts.org/privacy)

Unfortunately there's some confusion between off-dart and Smoothie.

off-dart version, method replaceSubdomainWithCodes in UriHelper:

  /// Replaces the subdomain of an URI with specific country and language.
  ///
  /// No default language nor country: null means no parameter.
  /// For instance
  /// * https://world.xxx... would be standard
  /// * https://world-fr.xxx... would be "no country" in French
  /// * https://fr.xxx... would be France
  /// * https://fr-es.xxx... would be France in Spanish
  static Uri replaceSubdomainWithCodes(
    final Uri uri, {
    final String? languageCode,
    String? countryCode,
  }) {

Smoothie version, method _replaceSubdomainWithCodes in LaunchUrlHelper:

  static String _replaceSubdomainWithCodes(String url) {
    if (!url.contains('https://openfoodfacts.')) {
      throw 'Error do not use local identifier in url';
    }

    String? countryCode =
        PlatformDispatcher.instance.locale.countryCode?.toLowerCase();

    if (countryCode == null) {
      countryCode = 'world.';
    } else {
      countryCode = '$countryCode.';
    }

    url = url.replaceAll(
        'https://openfoodfacts.', 'https://${countryCode}openfoodfacts.');

    return url;
  }

  static Future<void> launchURL(String url, bool isOFF) async {
    if (isOFF) {
      url = _replaceSubdomainWithCodes(url);
    }
// ...
  }

@AshAman999 I guess @teolemon is right and we should use my code suggestion. And merge the PR.

Meanwhile, I'm about to open an issue about using slightly different replaceSubdomainWithCodes and _replaceSubdomainWithCodes methods.

[teolemon]

Sorry I went through it too quickly. I just approved