Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moving email and newsletter up in contact page #5111

Conversation

gmmoraes
Copy link
Contributor

What

Moved both the email and newsletter up in contact page.

Screenshot

Before:
before_img

After:
after_img

Fixes bug(s)

  • Fixes:

Part of

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 9.53%. Comparing base (4d9c7fc) to head (b4d4943).
Report is 45 commits behind head on develop.

Files Patch % Lines
...ib/pages/preferences/user_preferences_connect.dart 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5111      +/-   ##
==========================================
- Coverage     9.54%   9.53%   -0.02%     
==========================================
  Files          325     327       +2     
  Lines        16411   16529     +118     
==========================================
+ Hits          1567    1576       +9     
- Misses       14844   14953     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmmoraes Looks good to me! Thank you and congratulations for your first PR!

@monsieurtanuki monsieurtanuki merged commit 44913af into openfoodfacts:develop Mar 10, 2024
6 checks passed
@gmmoraes
Copy link
Contributor Author

@monsieurtanuki , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send-us an email should be the first item in the Contact screen
3 participants