Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unused package percent_indicator #5308

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Removed a package dependency to percent_indicator, that would somehow be a duplicate of flutter_animation_progress_bar
  • Removed an unused related class.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.72%. Comparing base (4d9c7fc) to head (47459e9).
Report is 150 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5308      +/-   ##
==========================================
- Coverage     9.54%   7.72%   -1.83%     
==========================================
  Files          325     366      +41     
  Lines        16411   18504    +2093     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17074    +2230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, the kind of useless thing

@g123k g123k merged commit b6ad190 into openfoodfacts:develop May 30, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!
I guess it was a "just in case" class that got abandoned.
Speaking of which, please have a look at #5040 too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants