Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit page: fix regressions after migration to Material 3 #5781

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 2, 2024

Hi everyone,

Here are a few fixes for the Edit product page:

  • The background color in light mode is light brown
  • All icons are black in light mode

In general and not specific to this page, the weirdo effect of changing the AppBar color when scrolling is removed.

IMG_1278

@g123k g123k self-assigned this Nov 2, 2024
@g123k g123k linked an issue Nov 2, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 7.05%. Comparing base (4d9c7fc) to head (73f8f83).
Report is 422 commits behind head on develop.

Files with missing lines Patch % Lines
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% 2 Missing ⚠️
...ackages/smooth_app/lib/widgets/smooth_app_bar.dart 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5781      +/-   ##
==========================================
- Coverage     9.54%   7.05%   -2.50%     
==========================================
  Files          325     411      +86     
  Lines        16411   22236    +5825     
==========================================
+ Hits          1567    1569       +2     
- Misses       14844   20667    +5823     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @g123k

@teolemon teolemon merged commit 2fe8185 into openfoodfacts:develop Nov 3, 2024
7 checks passed
@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users light mode labels Nov 3, 2024
@g123k g123k deleted the edit_page_ui branch November 7, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users light mode 🥫 Product page
Development

Successfully merging this pull request may close these issues.

Edit page: some icons are black, some are grey
3 participants