Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change the onboarding for the AppStore + fix #6003

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 5, 2024

Hi everyone!

Apple asks us only to have one button for the permission page.
This also includes a fix, where right and left buttons were inverted.

@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 📈 Analytics We use Sentry and Matomo, with an opt-in system labels Dec 5, 2024
@g123k g123k linked an issue Dec 5, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 6.50%. Comparing base (4d9c7fc) to head (11cb048).
Report is 553 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/pages/onboarding/permissions_page.dart 0.00% 7 Missing ⚠️
...pp/lib/pages/onboarding/onboarding_bottom_bar.dart 0.00% 6 Missing ⚠️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% 2 Missing ⚠️
...s/smooth_app/lib/pages/onboarding/next_button.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6003      +/-   ##
==========================================
- Coverage     9.54%   6.50%   -3.05%     
==========================================
  Files          325     441     +116     
  Lines        16411   24982    +8571     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23358    +8514     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

teolemon commented Dec 5, 2024

@g123k can you provide a screenshot for reference?

1 similar comment
@teolemon
Copy link
Member

teolemon commented Dec 5, 2024

@g123k can you provide a screenshot for reference?

@teolemon teolemon merged commit af215e8 into openfoodfacts:develop Dec 5, 2024
6 checks passed
@g123k
Copy link
Collaborator Author

g123k commented Dec 5, 2024

IMG_1561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Development

Successfully merging this pull request may close these issues.

The update (4.17.0) is refused by Apple
3 participants