Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Product edition UI improvements #6320

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 31, 2025

Hi everyone!

As always, after the first PRs, a few refinements for the UI edition.

Upload banner & menu

Instead of being one on top of the other, the two are mixed
ScreenRecording_01-31-2025 20-19-35_1 (1)

Edition keyboard

On many fields, the first letter was in lowercase -> fixed
IMG_2112

Help

I think the UI is a bit better now
Untitled

Languages selector in dark mode

Untitled

@github-actions github-actions bot added 🥫 Product page 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Nutrition input 🖼️ Photos - Photo manager labels Jan 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 1.37615% with 215 lines in your changes missing coverage. Please review.

Project coverage is 5.92%. Comparing base (4d9c7fc) to head (84f34ff).
Report is 719 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/product/edit_product/edit_product_footer.dart 0.65% 152 Missing ⚠️
...pp/lib/generic_lib/widgets/languages_selector.dart 0.00% 16 Missing ⚠️
...nutrition_page/widgets/nutrition_facts_editor.dart 0.00% 8 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_banner.dart 0.00% 8 Missing ⚠️
...oth_app/lib/widgets/smooth_explanation_banner.dart 0.00% 7 Missing ⚠️
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% 6 Missing ⚠️
...ges/smooth_app/lib/helpers/collections_helper.dart 0.00% 5 Missing ⚠️
...roduct/product_page/footer/new_product_footer.dart 0.00% 4 Missing ⚠️
packages/smooth_app/lib/resources/app_icons.dart 25.00% 3 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6320      +/-   ##
==========================================
- Coverage     9.54%   5.92%   -3.63%     
==========================================
  Files          325     477     +152     
  Lines        16411   28337   +11926     
==========================================
+ Hits          1567    1678     +111     
- Misses       14844   26659   +11815     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Nutrition input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🖼️ Photos - Photo manager 🥫 Product page
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

2 participants