feat: #682 - add a "Clear all" menu item in the product history page #683
Conversation
…history page Impacted files: * `dao_product_list.dart`: added `clear` method * `product_list_dialog_helper.dart`: added `openClear` method * `product_list_page.dart`: added a "clear" menu item whenever relevant
There was a problem hiding this comment.
The code looks good, thanks @monsieurtanuki. just the CI, golden tests (screenshot tests) are complaining, but I actually don't know how they really work.
@Piinks can you help there, how are we supposed to check / regenerate them
| Future<void> clear(final ProductList productList) async => | ||
| localDatabase.database.transaction( | ||
| (final Transaction transaction) async { | ||
| final int? id = await _getId(productList, transaction); |
There was a problem hiding this comment.
I'am cusious, what happens when _getId retuns null
There was a problem hiding this comment.
@M123-dev You can find the answer in DaoProductExtra._getExtraKey. If I sum up, some lists will always be there and are always meaningful and unique (e.g. history, scan history). They don't need an id: there's only one scan history, we can give it the id 'scanHistory'. Other lists are user-defined: you can create them and delete them. They need a specific id, like list/$id.
|
Ohh, nevermind it started in #679, but still we need to regenerate the files |
Impacted files:
dao_product_list.dart: addedclearmethodproduct_list_dialog_helper.dart: addedopenClearmethodproduct_list_page.dart: added a "clear" menu item whenever relevant