Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency declarations #983

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 8, 2025

@mkllnk mkllnk self-assigned this Jan 8, 2025
@mkllnk mkllnk marked this pull request as ready for review January 8, 2025 04:42
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dacook
Copy link
Member

dacook commented Jan 10, 2025

Did a quick test:

~/projects/ofn-install $ brew update && brew upgrade pyenv # update packages on mac
...
~/projects/ofn-install $ ./bin/pyenv-install
Python 3.6.8
~/projects/ofn-install $ bin/setup
Starting galaxy role install process
- changing role geerlingguy.security from 1.5.0 to 1.5.0
- downloading role 'security', owned by geerlingguy
...
~/projects/ofn-install $ ansible-playbook playbooks/provision.yml -l au_staging
[DEPRECATION WARNING]: "include" is deprecated, use include_tasks/import_tasks instead. This feature will be removed in
 version 2.16. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
...
Failed to download remote objects and refs:  From https://github.com/nodenv/node-build
   43a77880..41c93786  main       -> origin/main
   43a77880..41c93786  master     -> origin/master
 ! [rejected]          v5         -> v5  (would clobber existing tag)
 * [new tag]           v5.3.23    -> v5.3.23

Oh that thing... 😒
Manually fixed and everything is otherwise fine ✅

TASK [notify slack] ****************************************************************************************************
ok: [staging.openfoodnetwork.org.au]

PLAY RECAP *************************************************************************************************************
staging.openfoodnetwork.org.au : ok=105  changed=3    unreachable=0    failed=0    skipped=60   rescued=0    ignored=0

@dacook dacook closed this Jan 10, 2025
@dacook dacook reopened this Jan 10, 2025
@dacook
Copy link
Member

dacook commented Jan 10, 2025

So GitHub has a great shortcut to submit a form from a textarea: cmd/ctrl+enter (I wish all websites and indeed browsers implemented this)
Apparently they also have a shortcut for the secondary actions: cmd/ctrl+shift+enter. Which is great unless you press it by accident.

@dacook dacook merged commit 27f1aab into openfoodfoundation:master Jan 10, 2025
4 checks passed
@mkllnk mkllnk deleted the jinja branch January 15, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to deploy with latest version of Jinja2
2 participants