🐛(back) manage subtitles content starting with a BOM #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
approved these changes
Jul 31, 2024
Comment on lines
+65
to
66
| timed_text = timed_text_file.read().replace("\ufeff", "") | ||
| reader = detect_format(timed_text) |
There was a problem hiding this comment.
Looks good as a workaround, but I feel this should be a contribution to pycaption, nope ?
There was a problem hiding this comment.
I don't know... pycaption accepts a string in input, now how you retrieve it. I will open an issue to know if there are interested for this contribution
There was a problem hiding this comment.
Issue created: pbs/pycaption#341
wilbrdt
approved these changes
Jul 31, 2024
When reading a subtitle content file uploaded, sometimes it starts with a Byte Order Mark and the srt reader is failing to detect the content as a srt one. We have to remove it before using the detect_format from the pycaption library.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When reading a subtitle content file uploaded, sometimes it starts with a Byte Order Mark and the srt reader is failing to detect the content as a srt one.
We have to remove it before using the detect_format from the pycaption library.
Proposal