Add newer tables to drop #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-kl1
reviewed
Jan 15, 2025
| `magento_banner`, | ||
| `magento_banner_catalogrule`, | ||
| `magento_banner_content`, | ||
| `magento_banner_customersegment`, | ||
| `magento_banner_salesrule`, | ||
| `magento_bulk`, |
There was a problem hiding this comment.
good catch, It used to be a time where it was EE restricted! 👴
thomas-kl1
reviewed
Jan 15, 2025
| @@ -54,7 +60,6 @@ DROP TABLE IF EXISTS | |||
| `magento_invitation_track`, | |||
| `magento_logging_event`, | |||
| `magento_logging_event_changes`, | |||
| `magento_operation`, | |||
There was a problem hiding this comment.
good catch, It used to be a time where it was EE restricted! 👴
thomas-kl1
requested changes
Jan 15, 2025
Comment on lines
+99
to
+106
| `sequence_catalog_category`, | ||
| `sequence_product`, | ||
| `sequence_catalogrule`, | ||
| `sequence_cms_block`, | ||
| `sequence_cms_page`, | ||
| `sequence_product_bundle_option`, | ||
| `sequence_product_bundle_selection`, | ||
| `sequence_salesrule`, |
There was a problem hiding this comment.
The sequence tables removal should be moved accordingly to the specific scripts available in this repo, so we have a clean view of what impact every component (product, category, salesrule...) have.
|
Thank you @LucaGallinari for your great contribution ❤️ I've noted that it's still in draft, but here my comments anyway 😄 |
|
Yes, i am working on it locally while we are doing a sidegrade, i'll comeback with some more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll comeback tomorrow with more insight regarding this PR 😄