Avoiding using QfTextField when we mix up other material controls & popup height fixes #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 6bc2684: arm64-android |
…with overlapping content
nirvn
changed the title
mohsenD98
approved these changes
Jan 31, 2025
|
@mohsenD98 , thanks for the review, quite happy about this cleanup here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the looks of a couple of dialogs as well as positioning device settings popup by moving away from QfTextField (still used in the feature form and a few other places) in favor of the default Material TextField implementation.
Beyond sitting better alongside Material ComboBox items, It comes with a couple of nice improvements:
I came to realize this was needed for us while developing the WebDAV stuff, and I just can't unsee this now.
E.g.: