Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.77 #2251

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Release 1.77 #2251

merged 3 commits into from
Aug 4, 2023

Conversation

PikkaPikkachu
Copy link
Contributor

@PikkaPikkachu PikkaPikkachu commented Aug 3, 2023

Tests

New Environment Variables
(Optional Section) Lists any new runtime environment variables that will be introduced in this release. Also, a gentle reminder to ensure that any new environment variables are documented in our README.md.

  • env_var: env var details

Home page

  • The landing page graphic should animate example short urls correctly
  • The landing page should have no link to search

Login page

  • OTP email should contain requestor's IP address
  • Resend OTP should send a new OTP to user, and invalidate previous OTP

User page

  • User message banner appears on top when USER_MESSAGE env var is set
  • Announcement modal appears when ANNOUNCEMENT_* env var is set
  • Banner follows scroll

QR

  • Downloaded PNG QR code should be of width 1000px and height >= 1000px
  • Downloaded SVG QR code should work
  • Scan the downloaded QR code in SVG to check that it points to the correct long url
  • Scan the downloaded QR code in PNG to check that it points to the correct long url

Directory - desktop view

  • It should redirect to the short url link when the row is clicked for active link

SGID Login

  • User should be routed to SGID authentication URL when they click Login with Singpass app
  • For health and edu domain, the user should get the message that they should login using email.
  • The user should be able to login using SGID successfully, if their work email is valid.

Directory - mobile view

  • It should redirect to the short url link when the redirect icon is clicked for active link in bottom mobile panel

Bulk upload

  • If bulk QR code is activated, in progress status bar should appear after uploading bulk file.
  • If bulk QR code is activated, in progress status bar should change to green within 2 mins after uploading bulk file.
  • Should be able to download csv, zipped png and zipped svg from success status bar
  • Downloaded csv should have all created links
  • Downloaded zipped QR code folders should have QR code files for all created links
  • Should receive email to download zipped png and zipped svg files

Deploy Notes

A new bash script for fetching environment variables from the AWS SSM store has been added in this release.

New environment variables:
SSM

  • SGID_CLIENT_ID :
  • SGID_CLIENT_SECRET:
  • SGID_PRIVATE_KEY:

Elastic Beanstalk

  • SSM_PREFIX:
  • SGID_API_HOSTNAME:

New dev dependencies:

  • dotenv : dotenv package loads the environment variables into application on runtime.

@mergify
Copy link

mergify bot commented Aug 3, 2023

⚠️ The sha of the head commit of this PR conflicts with #2250. Mergify cannot evaluate rules on this PR. ⚠️

Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PikkaPikkachu PikkaPikkachu merged commit 026e8fe into release Aug 4, 2023
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants