Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use explicit import for lodash (to reduce bundling whole lib) #774

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

karrui
Copy link
Collaborator

@karrui karrui commented Oct 10, 2024

refactor: use explicit import for lodash (to reduce bundling whole lib)

fix: mark sideEffects false for package

After

npm notice package size: 472.8 kB
npm notice unpacked size: 4.4 MB

When importing in a test app

To check for tree shake

Before

Screenshot 2024-10-10 at 1.20.02 PM.png

After

Screenshot 2024-10-10 at 1.19.43 PM.png

Copy link
Collaborator Author

karrui commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@karrui karrui marked this pull request as ready for review October 10, 2024 05:20
@karrui karrui merged commit 501af14 into main Nov 15, 2024
13 checks passed
@karrui karrui deleted the optimize-size branch November 15, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant