fix: reject utf8 emails in transactional endpoint #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishenKumarrrrr
force-pushed
the
fix/reject-utf8-emails
branch
2 times, most recently
from
a57ae9a to
f2ab76d
Compare
KishenKumarrrrr
had a problem deploying
to
staging
GitHub Actions
Failure
jia1
approved these changes
Aug 7, 2024
|
I assume we care only about recipient emails and nothing else. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In this PR, I modify the validation for the transactional email endpoint such that it rejects emails that contain UTF8 characters with a HTTP 400. In the current implementation, we allow for emails with UTF8 characters. However, these email addresses are ultimately rejected by AWS SES which result in a HTTP 500 being thrown from the transactional email endpoint. Since AWS SES currently does not support UTF8 characters in the local part of emails and there are no workarounds, the only option we have is to gracefully reject these email addresses.