feat: add profiler #2283
Merged
feat: add profiler #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in real life, the probability of >30 enabled profiling is 0.6%
|
jia1
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM, I don't see any breaking changes that apply to us (pertaining to dd-trace upgrade from v2 to v5). I also do not know of and cannot find a field/config inside tracer.init({ ... }) that directly configures the sampling rate for profiling, so this is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a continuation of #2282 . The purpose of turning on profiling is for us to collect some concrete data on what the exact bottleneck is during callbacks so we don't succumb to premature optimisation.
There is a risk that turning this feature on in production would be detrimental to the application performance. As such, I am only doing so for 20% of all our servers.