Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and remove unused ones #189

Closed
wants to merge 4 commits into from

Conversation

FlorianSW
Copy link
Member

@FlorianSW FlorianSW commented Apr 22, 2018

During this I also commited the package-lock.json file, which is recommended by npm guys. This pins our dependencies to specific versions.

Fixes #173

@digitaldan
Copy link
Contributor

Thanks! I notice a few major version increases in libraries, just curious how much of the system was tested, like email templates and other less obvious parts? The reason I ask is the last time we upgraded all the packages, little things broke everywhere :-)

@FlorianSW
Copy link
Member Author

I clicked through each view of the web frontend and tested all functionality I know (except OAuth2 apps itself, this would be something, which needs to be tested by someone who might have it setup locally already). I also haven't tested the stuff, that is not reachable from the frontend (e.g. the mentioned e-mail templates). So it might be good if someone else would be able to check all functions just to be save :)

@marziman
Copy link
Contributor

@FlorianSW,

thats risky. As @digitaldan mentioned this can lead to serious issues.

Can we first have this longer running with some tests.

I can try it out these days.

@digitaldan
Copy link
Contributor

@FlorianSW no worries, I will make sure I test the lesser used parts for this PR on my personal system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of node sources
3 participants