Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing manifest in bundle using SPM #833

Merged
merged 4 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions AppAuth.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -43,33 +43,33 @@ It follows the OAuth 2.0 for Native Apps best current practice

# Subspec for the core AppAuth library classes only, suitable for extensions.
s.subspec 'Core' do |core|
core.source_files = "Source/AppAuthCore.h", "Source/AppAuthCore/*.{h,m}"
core.source_files = "Sources/AppAuthCore.h", "Sources/AppAuthCore/*.{h,m}"
core.resource_bundles = {
"AppAuthCore_Privacy" => ["PrivacyInfo.xcprivacy"]
"AppAuthCore_Privacy" => ["Sources/AppAuthCore/Resources/PrivacyInfo.xcprivacy"]
}
end

# Subspec for the full AppAuth library, including platform-dependent external user agents.
s.subspec 'ExternalUserAgent' do |externalUserAgent|
externalUserAgent.dependency 'AppAuth/Core'

externalUserAgent.source_files = "Source/AppAuth.h", "Source/AppAuth/*.{h,m}"
externalUserAgent.source_files = "Sources/AppAuth.h", "Sources/AppAuth/*.{h,m}"

# iOS
externalUserAgent.ios.source_files = "Source/AppAuth/iOS/**/*.{h,m}"
externalUserAgent.ios.source_files = "Sources/AppAuth/iOS/**/*.{h,m}"
externalUserAgent.ios.deployment_target = ios_deployment_target
externalUserAgent.ios.frameworks = "SafariServices"
externalUserAgent.ios.weak_frameworks = "AuthenticationServices"

# macOS
externalUserAgent.osx.source_files = "Source/AppAuth/macOS/**/*.{h,m}"
externalUserAgent.osx.source_files = "Sources/AppAuth/macOS/**/*.{h,m}"
externalUserAgent.osx.deployment_target = osx_deployment_target
externalUserAgent.osx.weak_frameworks = "AuthenticationServices"
end

# Subspec for the full AppAuth library, including platform-dependent external user agents.
s.subspec 'TV' do |tv|
tv.source_files = "Source/AppAuthTV.h", "Source/AppAuthTV/*.{h,m}"
tv.source_files = "Sources/AppAuthTV.h", "Sources/AppAuthTV/*.{h,m}"
tv.dependency 'AppAuth/Core'
end

Expand Down
56 changes: 40 additions & 16 deletions AppAuth.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1000,6 +1000,7 @@
2D47AAD7249A86E30059B5A4 /* AppAuthTV */ = {
isa = PBXGroup;
children = (
7322C49B2BA20BFA00DF9B2F /* Resources */,
2D47AAD9249A87010059B5A4 /* OIDTVAuthorizationRequest.h */,
2D47AADD249A87010059B5A4 /* OIDTVAuthorizationRequest.m */,
2D47AADC249A87010059B5A4 /* OIDTVAuthorizationResponse.h */,
Expand Down Expand Up @@ -1055,10 +1056,9 @@
340E73731C5D819B0076B1F6 = {
isa = PBXGroup;
children = (
73F574332B7C42690023FFF0 /* PrivacyInfo.xcprivacy */,
341742291C5D84D0000EF209 /* Frameworks */,
341741FB1C5D82D3000EF209 /* UnitTests */,
341741AE1C5D8243000EF209 /* Source */,
341741AE1C5D8243000EF209 /* Sources */,
340E737D1C5D819B0076B1F6 /* Products */,
);
indentWidth = 2;
Expand Down Expand Up @@ -1090,7 +1090,7 @@
name = Products;
sourceTree = "<group>";
};
341741AE1C5D8243000EF209 /* Source */ = {
341741AE1C5D8243000EF209 /* Sources */ = {
isa = PBXGroup;
children = (
348970992178F40600ABEED4 /* CoreFramework */,
Expand All @@ -1103,7 +1103,7 @@
3489709E21791B0C00ABEED4 /* AppAuthCore.h */,
2D47AADB249A87010059B5A4 /* AppAuthTV.h */,
);
path = Source;
path = Sources;
sourceTree = "<group>";
};
341741FB1C5D82D3000EF209 /* UnitTests */ = {
Expand Down Expand Up @@ -1184,9 +1184,32 @@
path = LoopbackHTTPServer;
sourceTree = "<group>";
};
7322C4992BA2095100DF9B2F /* Resources */ = {
isa = PBXGroup;
children = (
73F574332B7C42690023FFF0 /* PrivacyInfo.xcprivacy */,
);
path = Resources;
sourceTree = "<group>";
};
7322C49A2BA20BEF00DF9B2F /* Resources */ = {
isa = PBXGroup;
children = (
);
path = Resources;
sourceTree = "<group>";
};
7322C49B2BA20BFA00DF9B2F /* Resources */ = {
isa = PBXGroup;
children = (
);
path = Resources;
sourceTree = "<group>";
};
8A9B9D5E24561EC40055353E /* AppAuthCore */ = {
isa = PBXGroup;
children = (
7322C4992BA2095100DF9B2F /* Resources */,
341741B41C5D8243000EF209 /* OIDAuthorizationRequest.h */,
341741B51C5D8243000EF209 /* OIDAuthorizationRequest.m */,
341741B61C5D8243000EF209 /* OIDAuthorizationResponse.h */,
Expand Down Expand Up @@ -1248,6 +1271,7 @@
8A9B9D632456227D0055353E /* AppAuth */ = {
isa = PBXGroup;
children = (
7322C49A2BA20BEF00DF9B2F /* Resources */,
340DAE241D581FE700EC285B /* macOS */,
F6F60FAF1D2BFEF000325CB3 /* iOS */,
);
Expand Down Expand Up @@ -2668,7 +2692,7 @@
"DEBUG=1",
"$(inherited)",
);
INFOPLIST_FILE = "$(SRCROOT)/Source/TVFramework/Info.plist";
INFOPLIST_FILE = Sources/TVFramework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
Expand Down Expand Up @@ -2700,7 +2724,7 @@
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
GCC_C_LANGUAGE_STANDARD = gnu11;
INFOPLIST_FILE = "$(SRCROOT)/Source/TVFramework/Info.plist";
INFOPLIST_FILE = Sources/TVFramework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MTL_FAST_MATH = YES;
Expand Down Expand Up @@ -3012,7 +3036,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/CoreFramework/Info.plist;
INFOPLIST_FILE = Sources/CoreFramework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Expand All @@ -3038,7 +3062,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/CoreFramework/Info.plist;
INFOPLIST_FILE = Sources/CoreFramework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Expand All @@ -3063,7 +3087,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Expand All @@ -3088,7 +3112,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
Expand Down Expand Up @@ -3142,7 +3166,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-watchOS";
Expand All @@ -3168,7 +3192,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-watchOS";
Expand All @@ -3193,7 +3217,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-tvOS";
Expand All @@ -3218,7 +3242,7 @@
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-tvOS";
Expand Down Expand Up @@ -3275,7 +3299,7 @@
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
FRAMEWORK_VERSION = A;
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-macOS";
Expand All @@ -3300,7 +3324,7 @@
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
FRAMEWORK_VERSION = A;
INFOPLIST_FILE = Source/Framework/Info.plist;
INFOPLIST_FILE = Sources/Framework/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "net.openid.AppAuth-macOS";
Expand Down
12 changes: 6 additions & 6 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ let package = Package(
targets: [
.target(
name: "AppAuthCore",
path: "Source/AppAuthCore",
resources: [.copy("../../PrivacyInfo.xcprivacy")],
path: "Sources/AppAuthCore",
resources: [.copy("Resources/PrivacyInfo.xcprivacy")],
publicHeadersPath: ""
),
.target(
name: "AppAuth",
dependencies: ["AppAuthCore"],
path: "Source/AppAuth",
path: "Sources/AppAuth",
sources: ["iOS", "macOS"],
resources: [.copy("../../PrivacyInfo.xcprivacy")],
resources: [.copy("Resources/PrivacyInfo.xcprivacy")],
publicHeadersPath: "",
cSettings: [
.headerSearchPath("iOS"),
Expand All @@ -63,8 +63,8 @@ let package = Package(
.target(
name: "AppAuthTV",
dependencies: ["AppAuthCore"],
path: "Source/AppAuthTV",
resources: [.copy("../../PrivacyInfo.xcprivacy")],
path: "Sources/AppAuthTV",
resources: [.copy("Resources/PrivacyInfo.xcprivacy")],
publicHeadersPath: ""
),
.testTarget(
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
16 changes: 16 additions & 0 deletions Sources/AppAuthCore/Resources/PrivacyInfo.xcprivacy
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyAccessedAPITypes</key>
<array>
</array>
<key>NSPrivacyCollectedDataTypes</key>
<array>
</array>
<key>NSPrivacyTrackingDomains</key>
<array/>
<key>NSPrivacyTracking</key>
<false/>
</dict>
</plist>
File renamed without changes.
16 changes: 16 additions & 0 deletions Sources/AppAuthTV/Resources/PrivacyInfo.xcprivacy
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyAccessedAPITypes</key>
<array>
</array>
<key>NSPrivacyCollectedDataTypes</key>
<array>
</array>
<key>NSPrivacyTrackingDomains</key>
<array/>
<key>NSPrivacyTracking</key>
<false/>
</dict>
</plist>
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions UnitTests/AppAuthTV/OIDTVAuthorizationRequestTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
#if SWIFT_PACKAGE
@import AppAuthTV;
#else
#import "Source/AppAuthCore/OIDScopeUtilities.h"
#import "Source/AppAuthCore/OIDURLQueryComponent.h"
#import "Source/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Source/AppAuthTV/OIDTVServiceConfiguration.h"
#import "Sources/AppAuthCore/OIDScopeUtilities.h"
#import "Sources/AppAuthCore/OIDURLQueryComponent.h"
#import "Sources/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Sources/AppAuthTV/OIDTVServiceConfiguration.h"
#endif

// Ignore warnings about "Use of GNU statement expression extension" which is raised by our use of
Expand Down
12 changes: 6 additions & 6 deletions UnitTests/AppAuthTV/OIDTVAuthorizationResponseTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
#if SWIFT_PACKAGE
@import AppAuthTV;
#else
#import "Source/AppAuthCore/OIDScopeUtilities.h"
#import "Source/AppAuthCore/OIDURLQueryComponent.h"
#import "Source/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Source/AppAuthTV/OIDTVAuthorizationResponse.h"
#import "Source/AppAuthTV/OIDTVServiceConfiguration.h"
#import "Source/AppAuthTV/OIDTVTokenRequest.h"
#import "Sources/AppAuthCore/OIDScopeUtilities.h"
#import "Sources/AppAuthCore/OIDURLQueryComponent.h"
#import "Sources/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Sources/AppAuthTV/OIDTVAuthorizationResponse.h"
#import "Sources/AppAuthTV/OIDTVServiceConfiguration.h"
#import "Sources/AppAuthTV/OIDTVTokenRequest.h"
#endif

/*! @brief Test value for the @c deviceAuthorizationEndpoint property.
Expand Down
10 changes: 5 additions & 5 deletions UnitTests/AppAuthTV/OIDTVTokenRequestTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
#if SWIFT_PACKAGE
@import AppAuthTV;
#else
#import "Source/AppAuthCore/OIDScopeUtilities.h"
#import "Source/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Source/AppAuthTV/OIDTVAuthorizationResponse.h"
#import "Source/AppAuthTV/OIDTVServiceConfiguration.h"
#import "Source/AppAuthTV/OIDTVTokenRequest.h"
#import "Sources/AppAuthCore/OIDScopeUtilities.h"
#import "Sources/AppAuthTV/OIDTVAuthorizationRequest.h"
#import "Sources/AppAuthTV/OIDTVAuthorizationResponse.h"
#import "Sources/AppAuthTV/OIDTVServiceConfiguration.h"
#import "Sources/AppAuthTV/OIDTVTokenRequest.h"
#endif

// Ignore warnings about "Use of GNU statement expression extension" which is
Expand Down
4 changes: 2 additions & 2 deletions UnitTests/OIDAuthStateTests.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
#if SWIFT_PACKAGE
@import AppAuthCore;
#else
#import "Source/AppAuthCore/OIDAuthStateChangeDelegate.h"
#import "Source/AppAuthCore/OIDAuthStateErrorDelegate.h"
#import "Sources/AppAuthCore/OIDAuthStateChangeDelegate.h"
#import "Sources/AppAuthCore/OIDAuthStateErrorDelegate.h"
#endif

@class OIDAuthState;
Expand Down
10 changes: 5 additions & 5 deletions UnitTests/OIDAuthStateTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
#if SWIFT_PACKAGE
@import AppAuthCore;
#else
#import "Source/AppAuthCore/OIDAuthState.h"
#import "Source/AppAuthCore/OIDAuthorizationResponse.h"
#import "Source/AppAuthCore/OIDErrorUtilities.h"
#import "Source/AppAuthCore/OIDRegistrationResponse.h"
#import "Source/AppAuthCore/OIDTokenResponse.h"
#import "Sources/AppAuthCore/OIDAuthState.h"
#import "Sources/AppAuthCore/OIDAuthorizationResponse.h"
#import "Sources/AppAuthCore/OIDErrorUtilities.h"
#import "Sources/AppAuthCore/OIDRegistrationResponse.h"
#import "Sources/AppAuthCore/OIDTokenResponse.h"
#endif

#import "OIDTokenRequestTests.h"
Expand Down
6 changes: 3 additions & 3 deletions UnitTests/OIDAuthorizationRequestTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
#if SWIFT_PACKAGE
@import AppAuthCore;
#else
#import "Source/AppAuthCore/OIDAuthorizationRequest.h"
#import "Source/AppAuthCore/OIDScopeUtilities.h"
#import "Source/AppAuthCore/OIDServiceConfiguration.h"
#import "Sources/AppAuthCore/OIDAuthorizationRequest.h"
#import "Sources/AppAuthCore/OIDScopeUtilities.h"
#import "Sources/AppAuthCore/OIDServiceConfiguration.h"
#endif

// Ignore warnings about "Use of GNU statement expression extension" which is raised by our use of
Expand Down
6 changes: 3 additions & 3 deletions UnitTests/OIDAuthorizationResponseTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
#if SWIFT_PACKAGE
@import AppAuthCore;
#else
#import "Source/AppAuthCore/OIDAuthorizationRequest.h"
#import "Source/AppAuthCore/OIDAuthorizationResponse.h"
#import "Source/AppAuthCore/OIDGrantTypes.h"
#import "Sources/AppAuthCore/OIDAuthorizationRequest.h"
#import "Sources/AppAuthCore/OIDAuthorizationResponse.h"
#import "Sources/AppAuthCore/OIDGrantTypes.h"
#endif

// Ignore warnings about "Use of GNU statement expression extension" which is raised by our use of
Expand Down
Loading
Loading