Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens rotation with additional headers - helper functions #854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojteklembryk
Copy link

Set of helpers to perform action with fresh tokens and additional headers in case of tokens rotation

@ywsang
Copy link

ywsang commented Apr 22, 2024

Hi @wojteklembryk, thanks for the PR! Would you be able to provide us with some info about your use case for such helper functions?

Copy link

@wahabniazi56 wahabniazi56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed very good addition, sometimes we need to pass headers in token requests. @mdmathias could you please merge into master?

@DanielRivers
Copy link

@ywsang A use case here is Kinde uses a header value in the request to determine which SDK is making the request.

@guilhermehmcarvalho
Copy link

Hi @wojteklembryk, thanks for the PR! Would you be able to provide us with some info about your use case for such helper functions?

I can say that DPoP implementation is one such case.

@wojteklembryk
Copy link
Author

wojteklembryk commented Oct 13, 2024

Hi everyone,
Apologies for the delayed response—I accidentally missed this thread.

@ywsang, there are several use cases that require passing additional headers during token rotation, such as:

  • DPoP, as mentioned by @guilhermehmcarvalho
  • Device fingerprinting
  • Bot protection
  • Passing additional metadata like the SDK version (as mentioned by @DanielRivers ) or device state
  • Tracing/observability

Overall, this PR does not introduce any new functionality; it simply exposes the changes introduced in #770 by @mdmathias.

Thanks for your suport and great work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants