8349509: [macos] Clean up macOS dead code in jpackage

[sashamatveev]

• Removed unused INSTALLER_SUFFIX bundler param.
• Removed unreachable if branch in MacAppImageBuilder.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349509: [macos] Clean up macOS dead code in jpackage (Enhancement - P4)

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23504/head:pull/23504
$ git checkout pull/23504

Update a local copy of the PR:
$ git checkout pull/23504
$ git pull https://git.openjdk.org/jdk.git pull/23504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23504

View PR using the GUI difftool:
$ git pr show -t 23504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23504.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349509: [macos] Clean up macOS dead code in jpackage

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• a0c7f66: 8349508: runtime/cds/appcds/TestParallelGCWithCDS.java should not check for specific output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sashamatveev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b83f0e82)

[sashamatveev]

/integrate

[openjdk]

Going to push as commit f0ea38b.
Since your change was applied there have been 11 commits pushed to the master branch:

• 7f6c687: 8349374: [JVMCI] concurrent use of HotSpotSpeculationLog can crash
• bd9b24c: 8349512: Duplicate PermittedSubclasses entries with doclint enabled
• b40f8ee: 8337251: C1: Improve Class.isInstance intrinsic
• 88a8483: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified
• fb847bb: 8349493: Replace sun.util.locale.ParseStatus usage with java.text.ParsePosition
• 7cd5cb2: 8349532: Refactor ./util/Pem/encoding.sh to run in java
• 86cec4e: 8343782: G1: Use one G1CardSet instance for multiple old gen regions
• 006ed5c: 8349375: Cleanup AIX special file build settings
• 3989a19: 8344925: translet-name ignored when package-name is also set
• 1eb54e4: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
• ... and 1 more: https://git.openjdk.org/jdk/compare/10791477cf0a0a31d2703fc718a7a649d494d534...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit f0ea38b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.