Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8.11.1 update cleanups #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jan 13, 2025

Some things were missed as part of: #264

  • The action to validate the gradle wrapper accidentally uses a deprecated version
  • The readme was not updated.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.org/jextract.git pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/272.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2025

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@JornVernee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Gradle 8.11.1 update cleanups

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@JornVernee JornVernee changed the title Gradle cleanups Gradle 8.11.1 update cleanups Jan 14, 2025
@JornVernee JornVernee marked this pull request as ready for review January 14, 2025 11:15
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant