Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
/ lanai Public archive

8226384: Implement a better logic to switch between OpenGL and Metal pipeline #183

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 11, 2021

This PR tries to remove lot of CGraphicsDevice.usingMetalPipeline() ifelse checks that are used to determine which CALayer to be used in classes like CPlatformView and CPlatformEmbeddedFrame. At other places where we use GraphicsDevice.usingMetalPipeline() is for initialization.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8226384: Implement a better logic to switch between OpenGL and Metal pipeline

Download

$ git fetch https://git.openjdk.java.net/lanai pull/183/head:pull/183
$ git checkout pull/183

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226384: Implement a better logic to switch between OpenGL and Metal pipeline

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • addfb6a: 8261143: Code in MTLGraphicsConfig.m can use ThreadUtilities performOnMainThreadWaiting:YES block:^()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready Pull request is ready to be integrated
Development

Successfully merging this pull request may close these issues.

1 participant