-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Windows support to kruise-daemon #1909
Open
ppbits
wants to merge
12
commits into
openkruise:master
Choose a base branch
from
ppbits:daemon-windows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ppbits <[email protected]>
Signed-off-by: ppbits <[email protected]>
Signed-off-by: ppbits <[email protected]>
Signed-off-by: ppbits <[email protected]>
Signed-off-by: ppbits <[email protected]>
3b36b53
to
5e45dd7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
+ Coverage 42.57% 42.75% +0.17%
==========================================
Files 313 314 +1
Lines 31364 31367 +3
==========================================
+ Hits 13354 13410 +56
+ Misses 16642 16589 -53
Partials 1368 1368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peng Peng <[email protected]>
2a00af2
to
f207c42
Compare
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
@furykerry Can I please have your review on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Update kruise-daemon to support Windows
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Tested on an AKS cluster with both Linux and Windows nodes:
We also tested with a
ContainerRecreateRequest
CR targeting a Windows container, and the container was successful recreated by the Windows kruise-daemon.Ⅳ. Special notes for reviews