Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Windows support to kruise-daemon #1909

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ppbits
Copy link
Contributor

@ppbits ppbits commented Feb 10, 2025

Ⅰ. Describe what this PR does

Update kruise-daemon to support Windows

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Tested on an AKS cluster with both Linux and Windows nodes:

  • CBL-Mariner/Linux
  • Windows Server 2022 Datacenter
  • Windows Server 2019 Datacenter

We also tested with a ContainerRecreateRequest CR targeting a Windows container, and the container was successful recreated by the Windows kruise-daemon.

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.75%. Comparing base (29258d3) to head (23080cd).

Files with missing lines Patch % Lines
pkg/daemon/criruntime/factory_unix.go 88.88% 7 Missing ⚠️
pkg/daemon/criruntime/factory.go 0.00% 3 Missing ⚠️
pkg/daemon/daemon.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
+ Coverage   42.57%   42.75%   +0.17%     
==========================================
  Files         313      314       +1     
  Lines       31364    31367       +3     
==========================================
+ Hits        13354    13410      +56     
+ Misses      16642    16589      -53     
  Partials     1368     1368              
Flag Coverage Δ
unittests 42.75% <83.58%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppbits ppbits marked this pull request as draft February 10, 2025 01:07
@ppbits ppbits changed the title Add Windows support to kruise-daemon [WIP] Add Windows support to kruise-daemon Feb 11, 2025
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
Signed-off-by: Peng Peng <[email protected]>
@ppbits ppbits marked this pull request as ready for review February 27, 2025 19:09
@ppbits
Copy link
Contributor Author

ppbits commented Feb 27, 2025

@furykerry Can I please have your review on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant