Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maplibre instead of mapbox style spec #940

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

ahocevar
Copy link
Member

I'm putting this up for discussion, as an alternative to #939.

The one thing that makes me hesitant to make this change is that I don't know what the plans are for Maplibre to stick with or depart from the Mapbox style spec. If someone from @maplibre, maybe @birkskyum, could comment on that, it would make the decision easier.

@ahocevar ahocevar marked this pull request as draft June 30, 2023 12:46
@birkskyum
Copy link

birkskyum commented Jun 30, 2023

Sure, since the Mapbox style spec has become proprietary, the plan for MapLibre is to continue developing the MapLibre Style Spec independently from Mapbox. The main divergence has so far been around atmosphere / globe features which were added after the fork, but the two style specs are still largely identical, and most changes happen as backwards-compatible additions, with both style specs still being on version 8.x.

@mbeckem
Copy link

mbeckem commented Sep 15, 2023

@ahocevar It appears that new versions of @mapbox/mapbox-gl-style-spec will also fall under the proprietary license as of this commit: mapbox/mapbox-gl-js@a02c71b. So switching to MapLibre Style Spec seems like a good idea moving forward.

@ahocevar
Copy link
Member Author

ahocevar commented Sep 15, 2023

@mbeckem Thanks for the pointer!

If you are interested in using this module in a manner not expressly permitted by its license, please do not hesitate to contact [email protected] with details of what you have in mind.

I'll do this first, and see what the options are.

@orangemug
Copy link
Contributor

I'm in favour of moving over to @maplibre/maplibre-gl-style-spec, reasons being:

  • we have an opportunity to discuss any changes with the maplibre team (because it's public)
  • the maplibre spec is open source, no issues with licensing
  • I'm personally building a tool on-top of maplibre/openlayer 😄

@ahocevar
Copy link
Member Author

Since I got no satisfying answer from Mapbox, I'm inclined to go in that direction too. But it's also tempting to create a new package, independent of both Mapbox and Maplibre, with a few more useful features (profiles, auto-generated docs, optimized for build size).

@orangemug
Copy link
Contributor

@ahocevar the spec is in progress over at https://github.com/maparatus/ol-mapbox-style-spec, rendered spec at https://maparatus.github.io/ol-mapbox-style-spec/ (I'll continue to update issue #10 on progress).

That's based on the maplibre-gl spec. I'm happy to transfer that repository over once I complete the tests and update the spec.

From my perspective. It'd be fine to merge this in the meantime, as it'd be closer to the incoming spec work.

@ahocevar ahocevar force-pushed the mapbox-to-maplibre-spec branch from 737f7e6 to 1fb1ba3 Compare January 28, 2025 11:01
@ahocevar ahocevar force-pushed the mapbox-to-maplibre-spec branch from 1fb1ba3 to 13c51d2 Compare January 28, 2025 11:57
@ahocevar
Copy link
Member Author

ahocevar commented Jan 28, 2025

Finishing this now, mostly to get rid of the extra tooling needed for flow types and stripping out unneeded properties from the spec.

No need any more for a build step for the esm version.

@ahocevar ahocevar marked this pull request as ready for review January 28, 2025 12:00
@ahocevar ahocevar merged commit 1aa4e8d into main Jan 28, 2025
1 check passed
@ahocevar ahocevar deleted the mapbox-to-maplibre-spec branch January 28, 2025 12:02
@HarelM
Copy link
Contributor

HarelM commented Jan 28, 2025

If there's anything we can help with, please ping me as I'm the lead maintainer for maplibre-gl-js and maplibre-style-spec for the js part of it.
Any help with PRs and maintenance would be very much welcome.
I'm also maintaining (on my free time) Maputnik, which has a way to switch to open-layer renderer, any help there would also be much appreciated. This tool is a good way to test things for maplibre-gl-js, I guess the same is true for this package as well.

@ahocevar
Copy link
Member Author

Thanks for your offer, @HarelM. Much appreciated. Not sure I'll be able to help much with what you're asking for though - I have a bunch of packages to maintain myself, and doing this all in my free time.

@ahocevar ahocevar mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants