-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use maplibre instead of mapbox style spec #940
Conversation
Sure, since the Mapbox style spec has become proprietary, the plan for MapLibre is to continue developing the MapLibre Style Spec independently from Mapbox. The main divergence has so far been around atmosphere / globe features which were added after the fork, but the two style specs are still largely identical, and most changes happen as backwards-compatible additions, with both style specs still being on version 8.x. |
@ahocevar It appears that new versions of |
@mbeckem Thanks for the pointer!
I'll do this first, and see what the options are. |
I'm in favour of moving over to
|
Since I got no satisfying answer from Mapbox, I'm inclined to go in that direction too. But it's also tempting to create a new package, independent of both Mapbox and Maplibre, with a few more useful features (profiles, auto-generated docs, optimized for build size). |
@ahocevar the spec is in progress over at https://github.com/maparatus/ol-mapbox-style-spec, rendered spec at https://maparatus.github.io/ol-mapbox-style-spec/ (I'll continue to update issue #10 on progress). That's based on the maplibre-gl spec. I'm happy to transfer that repository over once I complete the tests and update the spec. From my perspective. It'd be fine to merge this in the meantime, as it'd be closer to the incoming spec work. |
737f7e6
to
1fb1ba3
Compare
1fb1ba3
to
13c51d2
Compare
Finishing this now, mostly to get rid of the extra tooling needed for flow types and stripping out unneeded properties from the spec. No need any more for a build step for the esm version. |
If there's anything we can help with, please ping me as I'm the lead maintainer for maplibre-gl-js and maplibre-style-spec for the js part of it. |
Thanks for your offer, @HarelM. Much appreciated. Not sure I'll be able to help much with what you're asking for though - I have a bunch of packages to maintain myself, and doing this all in my free time. |
I'm putting this up for discussion, as an alternative to #939.
The one thing that makes me hesitant to make this change is that I don't know what the plans are for Maplibre to stick with or depart from the Mapbox style spec. If someone from @maplibre, maybe @birkskyum, could comment on that, it would make the decision easier.