Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Missing parameter for "Create network interface" #795

Merged

Conversation

Bischoff
Copy link
Contributor

One missing parameter found when comparing to source code.

@Bischoff Bischoff force-pushed the add-interface-missing-param branch from 5eb7f20 to ef96ad2 Compare December 31, 2023 13:01
@Bischoff Bischoff changed the title Missing parameter for "Create network interface" Doc: Missing parameter for "Create network interface" Dec 31, 2023
@bjhuangr bjhuangr force-pushed the add-interface-missing-param branch from ef96ad2 to 6bc8f00 Compare January 3, 2024 04:29
@Bischoff Bischoff force-pushed the add-interface-missing-param branch 2 times, most recently from 8f1d961 to b001b0a Compare January 4, 2024 11:41
Copy link
Contributor

@jackydalong jackydalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. The param hostname is missing in doc compared with the following code

zvmsdk/sdkwsgi/validation/parameter_types.py

network_list = {
    'type': 'array',
    'items': {
        'type': 'object',
        'properties': {
            'ip_addr': ipv4,
            'dns_addr': {'type': 'array',
                        'items': ipv4},
            'gateway_addr': ipv4,
            'mac_addr': mac_address,
            'cidr': cidr,
            'nic_vdev': vdev,
            'nic_id': {'type': 'string'},
            'osa_device': vdev,
            'hostname': hostname},    <------
        'dependencies': {
            'ip_addr': ['cidr']
        }
    },
    'additionalProperties': False
}

@bjhuangr bjhuangr force-pushed the add-interface-missing-param branch from b001b0a to f886e32 Compare January 8, 2024 05:09
@bjhuangr bjhuangr merged commit afda036 into openmainframeproject:master Jan 8, 2024
2 checks passed
@Bischoff Bischoff deleted the add-interface-missing-param branch February 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants