Add VM's active status in comments field of switch table #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it can be consumed by neutron-zvm-agent for attaching interface scenario. Signed-off-by: QingFeng Hao <[email protected]>
zhshuj
reviewed
Jan 16, 2024
| else: | ||
| comments = "{\"active\": false}" | ||
| LOG.info("Set comments to be %s in _dedicate_OSA." % comments) | ||
| self._NetDbOperator.switch_add_record(userid, vdev, comments=comments) |
There was a problem hiding this comment.
With line 3465 amd 3466 be commented out, the existing dedicate_OSA function would be broken.
And why line 3473 to line 3482 need be added here?
|
close as it's not needed with https://review.opendev.org/c/x/networking-zvm/+/905286 of the new solution proposed by @bjhuangr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it can be consumed by neutron-zvm-agent for attaching interface scenario.