[master]Change userid pattern to only support letters and numbers #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjhuangr @jichenjc @SeanHQF please help review, the issue is: https://github.ibm.com/zvc/planning/issues/15225#issuecomment-69477716 there're 2 solution for z/VM, after discussing with @SeanHQF, select 2, only support letters and numbers for z/VM userid(currently, the pattern is letters, numbers and underline） |
|
do you want to add some Unit test for this ? |
The character underline(_) is not supported by smapi, so remove it and only support letters and numbers. Signed-off-by: Xiao Feng Ren <[email protected]>
trenxiaof
force-pushed
the
rxf-change-userid-pattern-only-letters-and-numbers
branch
from
ac06077 to
75a9711
Compare
have added the cases to test the invalid userid, it can raise the regex patter not match errors. |
SeanHQF
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character underline(_) is not supported by smapi, so remove it and only support letters and numbers.