Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibm-validated behavior consistent in package_build.py #188

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Apurv428
Copy link
Collaborator

@Apurv428 Apurv428 commented May 8, 2024

Resolved issue #184
The PR modifies the script to standardize the behavior by allowing generation of all available ibm-validated distribution sources without requiring additional arguments, simplifying usage and aligning it with other functionalities.

Signed-off-by: Apurv Sonawane <[email protected]>
bin/package_build.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pleia2 pleia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first comment is that you should be more descriptive with your commit message title. "Updated script" is very vague. Which script? What are you fixing? It does need to be short, but it could be something like: Make ibm-validated behavior consistent in package_build.py

Next, you're using an older version of this script so it's non-functional in the current state. Always be sure you sync your repository with the master/main branch of the main project before proceeding.

In this case, the impacted component is line 266 where the URL has been replaced with the functional one: https://community.ibm.com/zsystems/api/oss/json

Even with that fix, it's still not working properly. Always be sure to test the script locally before you submit a PR. I've noted some of the changes you need below, but left the last puzzle for you.

bin/package_build.py Outdated Show resolved Hide resolved
bin/package_build.py Outdated Show resolved Hide resolved
bin/package_build.py Show resolved Hide resolved
@Apurv428 Apurv428 changed the title Updated Script Ibm-validated behavior consistent in package_build.py May 10, 2024
@Apurv428
Copy link
Collaborator Author

I will make the necessary changes.

@Apurv428 Apurv428 requested a review from pleia2 August 31, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants