-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibm-validated behavior consistent in package_build.py #188
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Apurv Sonawane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first comment is that you should be more descriptive with your commit message title. "Updated script" is very vague. Which script? What are you fixing? It does need to be short, but it could be something like: Make ibm-validated behavior consistent in package_build.py
Next, you're using an older version of this script so it's non-functional in the current state. Always be sure you sync your repository with the master/main branch of the main project before proceeding.
In this case, the impacted component is line 266 where the URL has been replaced with the functional one: https://community.ibm.com/zsystems/api/oss/json
Even with that fix, it's still not working properly. Always be sure to test the script locally before you submit a PR. I've noted some of the changes you need below, but left the last puzzle for you.
I will make the necessary changes. |
Signed-off-by: Apurv428 <[email protected]>
Resolved issue #184
The PR modifies the script to standardize the behavior by allowing generation of all available ibm-validated distribution sources without requiring additional arguments, simplifying usage and aligning it with other functionalities.