-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for survival biasing source normalization #3070
base: develop
Are you sure you want to change the base?
Add option for survival biasing source normalization #3070
Conversation
037573d
to
a1de119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yrrepy and sorry this one has lingered for a long time. I made a few updates here as did @pshriwise. Note that I changed the attribute wgt0
to wgt_born
to be consistent with other terminology in the code where we're referring to an attribute at the time a source particle was born.
I'm good with this now but would like to get approval from @pshriwise and @eepeterson too.
:survival_normalization: | ||
If this element is set to "true", this will enable the use of survival | ||
biasing source normalization, whereby the weight parameters, weight and | ||
weight_avg, are multiplied per history by the start weight of said history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the current implementation, if we stick with it we probably want to update this language from "history" to "particle".
FWIW I worked with this a little bit today using a test model that was a 10cmx10cmx10cm tungsten block (artificially high density) with a planar neutron source on the lower x/y plane, mono-directional in (0, 0, 1), and monoenergetic (14.1 MeV). I applied a weight window generator (using MAGIC) on a 100 x 100 x 100 mesh and here's what I saw:
Note that this is with the It would be good to test this for source weights as well as you said @yrrepy. Some sources of varying strengths with |
See #2673 for history.
Re-pull-requesting here as the code is re-synced with the latest dev branch.
@eepeterson
I believe most things from the original PR are addressed, though I have left the ability to switch it off (and thus a setting for).