-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hexagonal mesh model #3279
Draft
ebknudsen
wants to merge
16
commits into
openmc-dev:develop
Choose a base branch
from
ebknudsen:hexagonal_mesh
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hexagonal mesh model #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working in its own file for simplicity should eventually be merged into mesh.cpp
basically placeholders in its own file should ev. be megred into mesh.h
no need for mapping as we can get the indices directly from hex-coordinates
no need for mapping as we can get the indices directly from hex-coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in in progress - not ready for review yet
This PR introduces a hexagonal mesh as an alternative to rectilinear and cylindrical meshes. The implementation is intended to somewhat mimic the implementation of cylindrical meshes, and should function as a simple drop in substitution to the existing meshes.
It is possible that the functionality may be targeted through a lattice description instead, yet I believe this forms an easy-to-use and easy-to-grasp alternative. At present the code is contained in separate files hex_mesh.cpp/.h but it is intended to be merged into mesh once the code is mature.
Fixes # (issue)
Checklist