feat(istio): enable CNI in Istio configuration #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akafazov
force-pushed
the
fix/istio-cni
branch
from
99f55c0 to
2140463
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
nexus49
force-pushed
the
fix/istio-cni
branch
from
2140463 to
b49785d
Compare
|
Lets clarify if we should / need to the istio cni component. Also if we use it, if we should change the way we use the init sidecar of the containers |
istio-init is replaced by the istio-cni. We need this only for MacOS and Podman, but since it works everywhere we can opt to keep it as default? |
aaronschweig
force-pushed
the
fix/istio-cni
branch
from
4817f0f to
9d39b87
Compare
aaronschweig
force-pushed
the
fix/istio-cni
branch
from
9d39b87 to
87b18fc
Compare
aaronschweig
force-pushed
the
main
branch
2 times, most recently
from
baee0b2 to
ee27716
Compare
aaronschweig
force-pushed
the
fix/istio-cni
branch
from
87b18fc to
296fe1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The local-setup fails on MacOS when docker is used via podman and underlying FedoraOS vm.
The used
kindnetCNI remains, as istio-cni to designed to work with it. When using it, the istio-init is not used but istio-proxy still is and it works with the Istio-CNI and not with iptables.Additional info: https://istio.io/latest/docs/setup/additional-setup/cni/
Changes:
openmfp-systemnamespace