Separate out framework def as dataclass #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
commented
Dec 8, 2024
Comment on lines
+271
to
+273
| def __post_init__(self): | ||
| if isinstance(self.image, dict): | ||
| self.image = Image(**self.image) |
There was a problem hiding this comment.
This helps where framework namespaces were initiated based on nested dicts (loaded from configuration files). E.g.
framework = Framework(**{"name": ..., "image": {"author": ...}})correctly initializes an Image instance.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
=========================================
Coverage ? 70.08%
=========================================
Files ? 55
Lines ? 6835
Branches ? 0
=========================================
Hits ? 4790
Misses ? 2045
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mfeurer
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a Framework dataclass in favor of using a Namespace. The main advantages are type checks, IDE support, and validation. No real functional differences.
Because namespaces were used with "attribute access" (the
.notation), switching out a namespace for Framework instances doesn't require very invasive changes.Unfortunately, CI is a bit broken currently (AutoGluon used to be a reliable indicator until v1.2 broke that). But the unit tests pass, Random Forest passes, and AutoGluon-cholesterol passes, so I feel fairly confident about the change.
Part of #658 on a way to a better dev experience (#566).
@mfeurer It's been a long time since you agreed to do occasional PR reviews for AMLB. I understand if things changed and you are no longer available. If so, no hard feelings - just leave a message.