Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report icon #1190

Closed
wants to merge 2 commits into from
Closed

Report icon #1190

wants to merge 2 commits into from

Conversation

Munyua123
Copy link
Contributor

@Munyua123 Munyua123 commented Oct 30, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Screenshots

Related Issue

Other

@Munyua123
Copy link
Contributor Author

@denniskigen @ibacher Kindly review the above commit. its supposed to add the report icon to the esm-framework. Kindly review and approve

@ibacher
Copy link
Member

ibacher commented Oct 30, 2024

Please read the actual requirements about how PRs are meant to be constructed. Additionally, we should have a Jira ticket for this.

@Munyua123
Copy link
Contributor Author

@ibacher THe above is noted and will be implemented

@Munyua123 Munyua123 closed this Nov 2, 2024
@Munyua123 Munyua123 deleted the report-icon branch November 2, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Munyua123 @ibacher