-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4143: useLocations should support searching by tag or query… #1191
Conversation
I wasn't seeing any existing tests around these functions to update? What is our policy for tests around stuff like this? |
Size Change: -86.6 kB (-1.39%) Total Size: 6.13 MB
ℹ️ View Unchanged
|
@ibacher @denniskigen just a ping... thoughts on this one? I need this to be able to add the custom behavior to filter visit locations by the "Visit Location" tag while still maintaining the ability to search locations by string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mogoodrich. Mostly LGTM save for one concern about the URL construction.
Co-authored-by: Dennis Kigen <[email protected]>
… string
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
see: https://openmrs.atlassian.net/browse/O3-4143
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4143
Other