-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Use gender icons from icon framework in patient header #1208
Conversation
@@ -32,7 +32,7 @@ const GenderIcon = ({ gender }: GenderIconProps) => { | |||
return null; | |||
} | |||
|
|||
return <IconComponent />; | |||
return <IconComponent fill="#525252" />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibacher is there a better pattern for overriding the SVG fill color than this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I think that's (currently) the best version we have (ideally you could use CSS and thus Carbon's color tokens, but I don't think that fully works because of how CSS cascades).
Size Change: -139 kB (-2.22%) Total Size: 6.14 MB
ℹ️ View Unchanged
|
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR tweaks the patient header to reuse newly added gender icons from the framework.
Screenshots
Related Issue
Other