(fix) O3-4371: useFeatureFlag hook should not log an error if a feature flag does not exist #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibacher can you please review this pr.Thanks..! |
ibacher
requested changes
Jan 30, 2025
Comment on lines
23
to
24
| if (flags[flagName] === undefined) { | ||
| console.warn(`useFeatureFlag: Flag "${flagName}" does not exist. Returning false.`); |
There was a problem hiding this comment.
I don't think a warning is really any better. We don't need to log anything. It's fine.
| } | ||
| }, [flags[flagName]]); | ||
|
|
||
| return flags[flagName]?.enabled; | ||
| // Return false if flag does not exist or if it's off | ||
| return flags[flagName]?.enabled ?? false; |
ibacher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Fixed issue where useFeatureFlag logged an error for non-existent flags.
Changed behavior to return false for missing flags instead of logging an error.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4371
Other