(fix) O3-4270: Group obs by encounter instead of datetime (#2150)

openmrs · Jan 3, 2025 · 52b247f · 52b247f
1 parent a928b89
commit 52b247f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/packages/esm-generic-patient-widgets-app/src/obs-table/obs-table.component.tsx b/packages/esm-generic-patient-widgets-app/src/obs-table/obs-table.component.tsx
@@ -22,9 +22,11 @@ interface ObsTableProps {
 const ObsTable: React.FC<ObsTableProps> = ({ patientUuid }) => {
   const { t } = useTranslation();
   const config = useConfig();
-  const { data: obss, error, isLoading, isValidating } = useObs(patientUuid, config.showEncounterType);
-  const uniqueDates = [...new Set(obss.map((o) => o.issued))].sort();
-  const obssByDate = uniqueDates.map((date) => obss.filter((o) => o.issued === date));
+  const { data: obss } = useObs(patientUuid, config.showEncounterType);
+  const uniqueEncounterUuids = [...new Set(obss.map((o) => o.encounter.reference))].sort();
+  const obssGroupedByEncounters = uniqueEncounterUuids.map((date) =>
+    obss.filter((o) => o.encounter.reference === date),
+  );
 
   const tableHeaders = [
     { key: 'date', header: t('dateAndTime', 'Date and time'), isSortable: true },
@@ -40,7 +42,7 @@ const ObsTable: React.FC<ObsTableProps> = ({ patientUuid }) => {
 
   const tableRows = React.useMemo(
     () =>
-      obssByDate?.map((obss, index) => {
+      obssGroupedByEncounters?.map((obss, index) => {
         const rowData = {
           id: `${index}`,
           date: formatDatetime(new Date(obss[0].effectiveDateTime), { mode: 'wide' }),
@@ -91,7 +93,7 @@ const ObsTable: React.FC<ObsTableProps> = ({ patientUuid }) => {
 
         return rowData;
       }),
-    [config, obssByDate],
+    [config.data, config?.dateFormat, obssGroupedByEncounters],
   );
 
   const { results, goTo, currentPage } = usePagination(tableRows, config.table.pageSize);

diff --git a/packages/esm-generic-patient-widgets-app/src/resources/useObs.ts b/packages/esm-generic-patient-widgets-app/src/resources/useObs.ts
@@ -15,6 +15,10 @@ type ObsResult = fhir.Observation & {
   valueDateTime?: string;
   encounter?: {
     name?: string;
+    /**
+     * Reference to the encounter resource, in the format `Encounter/{uuid}`
+     */
+    reference: string;
   };
 };