Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4267: Align type tokens used in empty state tiles with designs #1457

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jan 20, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This fix addresses the empty state title's font, which differs from the font used when the data is filled. The empty state title now uses Body-compact-02 font style, with a font size of 16px, ensuring uniformity and compliance with the design guidelines

Screenshots

Appointment-App

screencast.2025-01-21.1.AM-43-40.mp4

Patient-lists-app

screencast.2025-01-21.7.PM-18-53.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-4267

Other

@jwnasambu jwnasambu marked this pull request as draft January 20, 2025 22:49
@jwnasambu jwnasambu marked this pull request as ready for review January 22, 2025 17:00
@denniskigen
Copy link
Member

Per this design clarification and this zeplin screen, the empty state tile content should use the heading-compact-02 type token instead.

@denniskigen denniskigen changed the title fix/O3-4267: The empty state title's font is different than the one with filled data (fix) O3-4267: Align type tokens used in empty state tiles with designs Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants