-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Set encounter and default role for encounter provider entity #542
Conversation
@icrc-psousa did you see the above build failure? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
============================================
+ Coverage 77.84% 77.89% +0.04%
- Complexity 2683 2706 +23
============================================
Files 239 239
Lines 7452 7507 +55
Branches 901 916 +15
============================================
+ Hits 5801 5847 +46
- Misses 1115 1116 +1
- Partials 536 544 +8 ☔ View full report in Codecov by Sentry. |
Issue was now addressed. Thanks for the heads-up @dkayiwa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @icrc-psousa! A few suggestions on how to better integrate this with the code base here.
Description of what I changed
This PR resolves the SQLIntegrityConstraintViolationException when creating an encounter via the FHIR API with a participant. The root cause was the EncounterProvider entity being flushed to the database before the Encounter was created, resulting in a null encounter_id. This update ensures the EncounterProvider entity is properly linked to the Encounter before being persisted.
Issue I worked on
see https://issues.openmrs.org/browse/FM2-639
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master