Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back createQueue method for backwards-compatibility #47

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mseaton
Copy link
Member

@mseaton mseaton commented Nov 22, 2023

No description provided.

@mseaton mseaton requested a review from mogoodrich November 22, 2023 20:32
@mseaton mseaton marked this pull request as ready for review November 22, 2023 20:32
@mseaton
Copy link
Member Author

mseaton commented Nov 22, 2023

@dkayiwa - I see you released 2.0.0 recently, but @mogoodrich just discovered this issue whereby the Initializer module is using a method I had removed in version 2.0.0. In order to better support this, this PR adds this method back in. We likely want to do a 2.0.1 maintenance release and update distros to use that instead.

@mseaton
Copy link
Member Author

mseaton commented Nov 22, 2023

No idea why the github action build is failing, but it didn't start with this commit, and it builds cleanly without errors for me locally, so it should be safe to ignore I think (though we should investigate)

@mseaton mseaton requested a review from dkayiwa November 22, 2023 20:39
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseaton mseaton merged commit a0773aa into main Nov 22, 2023
1 check failed
@mseaton mseaton deleted the create-queue branch November 22, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants