UHM-8309: prepend web app name to the returnUrl #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
reviewed
Feb 3, 2025
| @@ -55,6 +55,9 @@ class BreadCrumb extends Component { | |||
| familyName = patientHeaderDetail.person.personName.familyName; | |||
| } | |||
| let outputBreadcrumb; | |||
| const contextPath = window.location.href.split('/')[3]; | |||
| const url = localStorage.getItem('returnUrl'); | |||
| const returnUrl = `/${contextPath}/${url}`; | |||
There was a problem hiding this comment.
We may not care if this is not widely used, but generally I've seen code try to make this a bit more resilient to different configurations, specifically I would only add a "/" between the context path and the url if the url does not start with a "/".
There was a problem hiding this comment.
Thanks @mseaton ! I will remove the potentially extra "/".
Just FYI, besides the aesthetic aspect of the URL, the extra "/" are harmless, the browser ignores them, the following two URLs produce the same result with no errors or warnings:
mseaton
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.