Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: getCrossPlatformPathRegex don't return global regexs by default #739

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 12, 2025

getCrossPlatformPathRegex does not need to return a global regex as it is used in ESBuild filters.

Returning global regexs can be problematic when using regex.test(...) as it sets and use regex.lastIndex

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 8aa725f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.23% 1950 / 8046
🔵 Statements 24.23% 1950 / 8046
🔵 Functions 51.61% 112 / 217
🔵 Branches 71.34% 488 / 684
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/utils/regex.ts 100% 100% 100% 100%
Generated in workflow #963 for commit 8aa725f by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@739

commit: 8aa725f

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Feb 12, 2025

Thanks for the review!

@vicb vicb merged commit cc4f5f4 into main Feb 12, 2025
3 checks passed
@vicb vicb deleted the vb-branch-2 branch February 12, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants